Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

U4-5683 Migrate Dictionary tree & editor to angular #2159

Merged
merged 134 commits into from
Jun 13, 2018
Merged

U4-5683 Migrate Dictionary tree & editor to angular #2159

merged 134 commits into from
Jun 13, 2018

Conversation

dawoe
Copy link
Contributor

@dawoe dawoe commented Aug 30, 2017

PR for Migrate Dictionary http://issues.umbraco.org/issue/U4-5683

dawoe added 30 commits July 20, 2017 17:07
@dawoe
Added new treecontroller for dictionairy and marked legacy tree as ob…
c175c72 
…solete
@dawoe
Load root dictionairy items in tree
2799f2c
@dawoe
Enabled loading of sub dictionary items in dictionary tree
934666f
@dawoe
Added the reload nodes menu action to dictionairy nodes
9821f7f
@dawoe
Added delete action to items in dictionary tree
3baaa41
@dawoe
Added delete view for dictionary with needed markup
f51604e
@dawoe
Added angular dictionary resource
b51bc09
@dawoe
Added new treecontroller for dictionairy and marked legacy tree as ob…
0baae65 
…solete
@dawoe
Load root dictionairy items in tree
cb33ef0
@dawoe
Enabled loading of sub dictionary items in dictionary tree
f7d72bc
@dawoe
Added the reload nodes menu action to dictionairy nodes
7eb7d1d
@dawoe
Added delete action to items in dictionary tree
f62e466
@dawoe
Added delete view for dictionary with needed markup
fa9044c
@dawoe
Added angular dictionary resource
552198c
@dawoe
Merge branch 'U4-5863' of https://github.com/dawoe/Umbraco-CMS into U…
1810500 
…4-5863
@dawoe
Added dictionary api controller with method to delete dictionary items
109810f
@dawoe
Added dictionary api base url to server variables
df370ed
@dawoe
Added delete by id method to dictionary resource
99334c4
@dawoe
Fix create dialog on old dictionary tree
7818450
@dawoe
Added dictionary delelte controller and added cancel method
7f058d2
@dawoe
Order items in dictionairy tree by key
136f154
@dawoe
Added detele function to angular controller
8330986
@dawoe
Added new treecontroller for dictionairy and marked legacy tree as ob…
d177acb 
…solete
@dawoe
Load root dictionairy items in tree
9751b2e
@dawoe
Enabled loading of sub dictionary items in dictionary tree
55128fc
@dawoe
Added the reload nodes menu action to dictionairy nodes
f9c0f2e
@dawoe
Added delete action to items in dictionary tree
447a6da
@dawoe
Added delete view for dictionary with needed markup
0946fa9
@dawoe
Added angular dictionary resource
40a62c6
@dawoe
Added new treecontroller for dictionairy and marked legacy tree as ob…
f135911 
…solete
@dawoe
Copy link
Contributor Author

dawoe commented Dec 12, 2017

Everything is migrated..old tree still needs to get cleaned up

@nul800sebastiaan
Copy link
Member

Thanks @dawoe. just want to let you know we've seen this massive update and we'll get back to you soon. Thanks very much for the effort so far! #h5yr

@dawoe
Copy link
Contributor Author

dawoe commented Jan 11, 2018

Hi @nul800sebastiaan

Any news on this one ?

Dave

@dawoe dawoe changed the base branch from dev-v7 to dev-v7.8 January 11, 2018 15:15
@dawoe dawoe changed the base branch from dev-v7.8 to dev-v7 January 11, 2018 15:42
@dawoe
Merge branch 'dev-v7' into U4-5863
f3335ec 
# Conflicts:
#	src/Umbraco.Web/Editors/BackOfficeServerVariables.cs
@dawoe
Copy link
Contributor Author

dawoe commented Mar 21, 2018

Any news on this one ?

@dawoe dawoe changed the title U4-5863 Migrate Dictionary tree & editor to angular U4-5683 Migrate Dictionary tree & editor to angular Mar 22, 2018
@nul800sebastiaan nul800sebastiaan merged commit 9c33f1b into umbraco:dev-v7 Jun 13, 2018
@nul800sebastiaan
Copy link
Member

nul800sebastiaan commented Jun 13, 2018 •
edited

This is amazing Dave, I've spent the day looking at this one and making some small changes to the coding style aaaaannddd...... with my additional changes we can now move the tree to the translation section too! 🎉 🎉

AWESOME job mate and very sorry for the delay!!
7.11 is going to be a super fun release thanks to you!

FYI, to move the dictionary tree to the translation section, change:

<add application="settings" alias="dictionary" title="Dictionary" type="Umbraco.Web.Trees.SettingsDictionaryTreeController, umbraco" iconClosed="icon-folder" iconOpen="icon-folder" sortOrder="6" />

To:

<add application="translation" alias="dictionary" title="Dictionary" type="Umbraco.Web.Trees.TranslationDictionaryTreeController, umbraco" iconClosed="icon-folder" iconOpen="icon-folder" sortOrder="3" />

@dampee
Copy link
Contributor

dampee commented Jun 14, 2018

Awesome!

@marcemarc
Copy link
Contributor

Wowsers, let us remember this day for many years to come!

@dawoe dawoe deleted the U4-5863 branch June 18, 2018 06:45
@dawoe dawoe mentioned this pull request Jul 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dawoe @nul800sebastiaan @dampee @marcemarc